Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: refactor maybeCallback function #52129

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fs: refactor maybeCallback function #52129

merged 1 commit into from
Mar 19, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Mar 17, 2024

Small refactor to simplify and remove maybeCallback function.

cc @nodejs/fs

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Mar 17, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57806/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57808/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 61e5de1 into nodejs:main Mar 19, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 61e5de1

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@anonrig @rdw-msft
fs: refactor maybeCallback function
f332820 
PR-URL: nodejs#52129
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@anonrig @marco-ippolito
fs: refactor maybeCallback function
e05255d 
PR-URL: #52129
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@anonrig @marco-ippolito
fs: refactor maybeCallback function
c5fd193 
PR-URL: #52129
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anonrig @nodejs-github-bot @ShogunPanda @lpinca @targos