test_runner: make end of work check stricter #52326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the logic that checks for the end of the test run. Prior to this change, it was possible for root.run() to be called multiple times because of the way pending subtests were tracked. The extra calls to root.run() were harmless, but could trigger an EventEmitter leak warning due to 'abort' listeners being created.
|
Review requested:
|
benjamingr
approved these changes
Apr 2, 2024
MoLow
approved these changes
Apr 2, 2024
atlowChemi
approved these changes
Apr 3, 2024
cjihrig
added
request-ci
github-actions
bot
removed
the
request-ci
|
@MoLow do you know if there is anything that can be done on the build side? It seems like macOS has been having a tough time in the CI the past day or so. I keep seeing FWIW, this commit seems to help with some test runner flakiness in the CI. |
cjihrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 52f8dcf |
|
This needs a backport on v20.x |
marco-ippolito
added
the
backport-requested-v20.x
atlowChemi
pushed a commit
to atlowChemi/node
that referenced
this pull request
May 23, 2024
This commit updates the logic that checks for the end of the test run. Prior to this change, it was possible for root.run() to be called multiple times because of the way pending subtests were tracked. The extra calls to root.run() were harmless, but could trigger an EventEmitter leak warning due to 'abort' listeners being created. PR-URL: nodejs#52326 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
atlowChemi
added
the
backport-open-v20.x
atlowChemi
removed
the
backport-requested-v20.x
marco-ippolito
pushed a commit
to atlowChemi/node
that referenced
this pull request
Jun 12, 2024
This commit updates the logic that checks for the end of the test run. Prior to this change, it was possible for root.run() to be called multiple times because of the way pending subtests were tracked. The extra calls to root.run() were harmless, but could trigger an EventEmitter leak warning due to 'abort' listeners being created. PR-URL: nodejs#52326 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the logic that checks for the end of the test run. Prior to this change, it was possible for
root.run()to be called multiple times because of the way pending subtests were tracked. The extra calls toroot.run()were harmless, but could trigger anEventEmitterleak warning due to'abort'listeners being created.