Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 10.5.1 #52351

Merged
merged 1 commit into from Apr 7, 2024
Merged

deps: upgrade npm to 10.5.1 #52351

merged 1 commit into from Apr 7, 2024

Conversation

npm-cli-bot
Copy link
Contributor

10.5.1 (2024-04-03)

Bug Fixes

Documentation

Dependencies

Chores

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Apr 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@lukekarrys lukekarrys added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2024
mhdawson
mhdawson approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@dominicfraser dominicfraser mentioned this pull request Apr 3, 2024
Closed
2 tasks
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58073/

VoltrexKeyva
VoltrexKeyva approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58085/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58090/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58116/

UlisesGascon
UlisesGascon approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I checked the licenses too following this script

@wraithgar
Copy link

LGTM! I checked the licenses too following this script

npm also does license checking as part of its release process. The hiccup in the past was because blueOak wasn't explicitly in the openjs list. That is the only non CC-BY-3.0 license in our license linter, so unless you see that file change this shouldn't be worth thinking about

Current .licensee.json file:

{
  "licenses": {
    "spdx": [
      "CC-BY-3.0"
    ],
    "blueOak": "bronze"
  },
  "corrections": true
}

In the npm repo you can run npm run licenses to validate against this list.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58124/

@melroy89 melroy89 mentioned this pull request Apr 5, 2024
Open
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58150/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit ad86a12 into nodejs:main Apr 7, 2024
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ad86a12

@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
richardlau pushed a commit that referenced this pull request Apr 26, 2024
@npm-cli-bot @richardlau
deps: upgrade npm to 10.5.1
052b0ba 
PR-URL: #52351
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@npm-cli-bot @marco-ippolito
deps: upgrade npm to 10.5.1
24bd695 
PR-URL: #52351
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Open
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@npm-cli-bot @marco-ippolito
deps: upgrade npm to 10.5.1
0a103e9 
PR-URL: #52351
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys approved these changes

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@mhdawson mhdawson mhdawson approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@npm-cli-bot @nodejs-github-bot @wraithgar @lukekarrys @lpinca @UlisesGascon @mhdawson @marco-ippolito @VoltrexKeyva @richardlau