Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: migrate to new V8 interceptors API #52745

Merged
merged 1 commit into from
May 1, 2024
Merged

src: migrate to new V8 interceptors API #52745

merged 1 commit into from
May 1, 2024

Conversation

targos
Copy link
Member

@targos targos commented Apr 29, 2024

Refs: v8#180

@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v21.x PRs that should not land on the v21.x-staging branch and should not be released in v21.x. labels Apr 29, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58799/

@targos
Copy link
Member Author

targos commented Apr 30, 2024

@nodejs/vm

@targos
Copy link
Member Author

targos commented Apr 30, 2024

/cc @nodejs/cpp-reviewers

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit d6b12f5 into nodejs:main May 1, 2024
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d6b12f5

@targos targos deleted the v8-interceptors branch May 1, 2024 19:15
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@targos @Ch3nYuY
src: migrate to new V8 interceptors API
29e334b 
Refs: v8#180
PR-URL: nodejs#52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos added a commit that referenced this pull request May 8, 2024
@targos
src: migrate to new V8 interceptors API
323f95d 
Refs: v8#180
PR-URL: #52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This was referenced May 13, 2024
Open
Merged
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@targos @lukins-cz
src: migrate to new V8 interceptors API
a0fbfc8 
Refs: v8#180
PR-URL: nodejs#52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v21.x PRs that should not land on the v21.x-staging branch and should not be released in v21.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@targos @nodejs-github-bot @Qard @anonrig @isheludko