test_runner: refactor to use min/max of validateInteger
#53148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
27e689b
to
96c85c0
Compare
cjihrig
approved these changes
May 25, 2024
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
96c85c0
to
91c4c7b
Compare
atlowChemi
approved these changes
May 25, 2024
atlowChemi
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
MoLow
approved these changes
May 25, 2024
lpinca
approved these changes
May 27, 2024
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
91c4c7b
to
1044590
Compare
github-actions
bot
removed
the
request-ci
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`.
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
1044590
to
1f4e73c
Compare
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
May 30, 2024
deokjinkim
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 88d3952 |
targos
pushed a commit
that referenced
this pull request
Jun 3, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: #53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: nodejs#53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: nodejs#53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of additional
ifstatement, use min/max ofvalidateIntegerforshard.index.