[v20.x backport] watch: fix arguments parsing #53162
Conversation
PR-URL: nodejs#52760 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
nodejs-github-bot
added
needs-ci
|
I would not assume #52760 needs manual backporting without @nodejs/releasers requesting for it |
MoLow
changed the title
|
Hi @MoLow I think this commit should fix a regression which was introduced in
Do you mean the fix will be automatically back-ported into |
yes, that is usually how backporting is done. manual backporting is needed only in case there are conflicts/CI fails etc |
|
Oh thanks a lot! Shall I close this PR instead? If so I will leave a comment under #53102 to explain that the fix shall be back ported by the nodejs/releasers team. |
|
lets wait for an answer from @nodejs/releasers |
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
07c45ba
to
e6d9fbe
Compare
|
usually it needs to stay 2 weeks in the current in order to be able to be backported (if the original commit does not land cleanly) |
|
Thanks @marco-ippolito! Does that mean I can close this PR and wait for the backport? |
|
Id say keep it open until it the original gets released, if doesnt land cleanly we have the backport ready |
|
Closing as the original commit lands cleanly 739adf90b1 |
Fixes: #53102
PR-URL: #52760
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Raz Luvaton rluvaton@gmail.com