Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,permission: handle process.chdir on pm #53175

Merged
merged 1 commit into from
Jun 1, 2024
Merged

src,permission: handle process.chdir on pm #53175

merged 1 commit into from
Jun 1, 2024
+13 −0

Conversation

RafaelGSS
Copy link
Member

Follow up https://hackerone.com/reports/2469792.

This should be handled in public.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label May 27, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 27, 2024
RedYetiDev
RedYetiDev approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@RedYetiDev RedYetiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59469/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59523/

@RedYetiDev
Copy link
Member

RedYetiDev commented May 30, 2024 •
edited
Loading

nit: is there a reason why the commit category for this is permission, and #53124 is pm in the title, permission is the right one, correct?

(Just making sure I'm not crazy 😅 )

@RafaelGSS
Copy link
Member Author

Reference in ne

permission is the correct one, I'll adjust that. Thanks for pointing that out.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59578/

@RafaelGSS RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. labels May 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59581/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59587/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59597/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 02079b6 into nodejs:main Jun 1, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 02079b6

targos pushed a commit that referenced this pull request Jun 3, 2024
@RafaelGSS @targos
src,permission: handle process.chdir on pm
e26166f 
PR-URL: #53175
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@RafaelGSS @EliphazBouye
src,permission: handle process.chdir on pm
587291b 
PR-URL: nodejs#53175
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@RafaelGSS @bmeck
src,permission: handle process.chdir on pm
a125a19 
PR-URL: nodejs#53175
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@H4ad H4ad H4ad approved these changes

@RedYetiDev RedYetiDev RedYetiDev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RafaelGSS @nodejs-github-bot @RedYetiDev @anonrig @H4ad