assert,util: change WeakMap and WeakSet comparison handling #53495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
BridgeAR
reviewed
Jun 18, 2024
BridgeAR
approved these changes
Jun 18, 2024
github-actions
bot
removed
the
request-ci
|
@synapse just a small nit that does not have to be followed up upon: We have a commit message rule about adding the subsystem to each commit. In this specific case it could e.g., look like: |
BridgeAR
added
the
semver-major
tniessen
changed the title
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jun 19, 2024
BridgeAR
added
the
author ready
benjamingr
approved these changes
Jun 19, 2024
MoLow
approved these changes
Jun 20, 2024
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jun 21, 2024
JungMinu
approved these changes
Jun 22, 2024
BridgeAR
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53495 ✔ Done loading data for nodejs/node/pull/53495 ----------------------------------- PR info ------------------------------------ Title assert,util: change WeakMap and WeakSet comparison handling (#53495) Author Cristian Barlutiu (@synapse, first-time contributor) Branch synapse:weak-handle -> nodejs:main Labels assert, util, semver-major, author ready, commit-queue-rebase Commits 1 - assert,util: change WeakMap and WeakSet comparison handling Committers 1 - Cristian Barlutiu PR-URL: https://github.com/nodejs/node/pull/53495 Reviewed-By: Matteo Collina Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53495 Reviewed-By: Matteo Collina Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 18 Jun 2024 06:26:58 GMT ✔ Approvals: 7 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2125017937 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2125500391 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2127119543 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2129045696 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2129451730 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53495#pullrequestreview-2133314585 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/53495#pullrequestreview-2133810643 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-06-25T13:43:09Z: https://ci.nodejs.org/job/node-test-pull-request/59964/ - Querying data for job/node-test-pull-request/59964/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9682614533 |
|
Does anyone know why fedora always fails? I will start the CI again. |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9cd9aa8...764b13d |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
PR-URL: #53495 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18227
As discussed in the task I've added :
WeakSetorWeakMapand compare their instanceWeak*instances comparison