crypto: make deriveBits length parameter optional and nullable #53601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
crypto
panva
force-pushed
the
derive-bits-optional-nullable
branch
from
beb1a09
to
b348936
Compare
|
cc @twiss, in case you want to track the implementation status of w3c/webcrypto#345 |
lpinca
approved these changes
Jun 27, 2024
benjamingr
approved these changes
Jun 27, 2024
panva
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d65b170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SubtleCrypto.prototype.deriveBits as per w3c/webcrypto#345