doc: avoid hiding by navigation bar in anchor jumping in 17.x

[cloydlau]

See: #45131 (comment)

Merging into the v17.x branch should only affect the documentation for Node 17.

[nodejs-github-bot]

Review requested:

• @nodejs/nodejs-website

[richardlau]

Node.js 17 is End-of-Life and will not get new versions.

[cloydlau]

It's sad but the original PR was proposed in 2022. I guess at that time, Node 17 hadn't reached EOL yet?

Two years later, the original PR was suddenly merged into the main branch (targeting the current 22.x), which caused unexpected issues.

[jwueller]

Node.js 17 is End-of-Life and will not get new versions.

It is still valuable to at least have functional documentation for older versions, even if it's just for reference. Why is this tied to Node.js releases?

[ovflowd]

The issue here, @jwueller is that for the v17 docs to get updated with the current workflow, it'd require a new release of Node.js v17.

[ovflowd]

I know this got approved, but I doubt this (even if merged) would have any effect at all. I'm closing this PR but more than happy to reopen if the author requests.

[jwueller]

The issue here, @jwueller is that for the v17 docs to get updated with the current workflow, it'd require a new release of Node.js v17.

Hm, that does seem like a flaw, yeah.

I know this got approved, but I doubt this (even if merged) would have any effect at all. I'm closing this PR but more than happy to reopen if the author requests.

Wouldn't it make more sense to still merge, so it would at least not get lost in case 17 does end up with a new release for some reason? Exceptions might be made for critical security issues, even if no longer officially supported, for example. It would also fix any local builds someone might make of 17 for any reason.

Or do you think this change would be too risky to include in such a hotfix?

[ovflowd]

Or do you think this change would be too risky to include in such a hotfix?

Not about risks, but Node.js v17 is beyond EOL... I'd like to consult with @nodejs/releasers if we have any practice for security hotfixes.

Also, in general, security hotfixes apply commits from upstream to a certain branch, and I am not sure how it works with a specific release line branch. I'll defer this to our Releasers team.

I'd be more than happy to have this land if there's any chance of this commit actually surfacing the light of the day.

[jwueller]

Not about risks, but Node.js v17 is beyond EOL... I'd like to consult with @nodejs/releasers if we have any practice for security hotfixes.

Depending on the extent, even some EOL software tends to receive critical security hotfixes in some cases. But you're right, it would certainly be an extraordinary circumstance.

[richardlau]

They're rare -- I only remember one and that happened within the month after the release went End-of-Life. We do not have the capacity to evaluate whether End-of-Life releases are vulnerable to any newly reported issues (we just assume they are and recommend updating).