-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for network interfaces #543
Conversation
I'm inclined to accept this because changing os.networkInterfaces() behavior w.r.t. offline interfaces would constitute a rather large break with joyent/node. Can other contributors weigh in? @toddself Can you update the commit log per the guidelines in CONTRIBUTING.md? Please wrap long lines at 80 columns. Thanks! |
Adding "down" interfaces might be a nice addition. It would also be nice to tell by an extra property whether it's "down" or not though, or maybe we could group them (e.g. |
Sorry! Updated with 80 column breaks. |
@toddself Can you update the commit log one more time, please? :-) The first line should be |
@bnoordhuis is that what you meant in your last comment? or do i need to do a |
@toddself Please --amend it, yes. |
@bnoordhuis thank you for the assistance on this! I tried to follow the format of previous commits that resolve an issue in the list. |
@toddself Thanks, that looks great! Landed in 8b1db9c. |
doc: note that only active network ifaces appear
A proposal to fix #498 by clarifying the documentation.