Enable linting for benchmarks #5517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
benchmark
| @@ -15,7 +16,8 @@ var bench = common.createBenchmark(main, { | |||
|
|
|||
| function main(conf) { | |||
| var iter = (conf.iter) * 100000; | |||
| var aliceBuffer = fs.readFileSync(__dirname + '/../fixtures/alice.html'); | |||
| var aliceBuffer = fs.readFileSync( | |||
| path.resolve(__dirname, '../fixtures/alice.html')); | |||
There was a problem hiding this comment.
Wouldn't having the last parenthesis on the next line be more consistent (and IMHO better looking) with the changes made in benchmark/compare.js?
There was a problem hiding this comment.
Agreed. Will change and push.
|
Fixup commit pushed based on @mscdex feedback. PTAL. |
|
LGTM if CI is still ok with it |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
Looks like the PR may need a quick rebase and update before landing. |
|
@jasnell Rebased! |
jasnell
pushed a commit
that referenced
this pull request
Mar 3, 2016
PR-URL: #5517 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 3, 2016
PR-URL: #5517 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 1bedeeb and 6d22003 |
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
PR-URL: #5517 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
PR-URL: #5517 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
PR-URL: #5517 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
PR-URL: #5517 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@Trott this one too for benchmarking backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor benchmarks to conform with existing lint rules. (In the process, a few broken benchmarks were fixed, e.g. the one for domains.) Enable linting for benchmarks.
/cc @nodejs/benchmarking @mscdex