Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: replace util._extend() with Object.create() #592

Closed
wants to merge 1 commit into from
Closed

http: replace util._extend() with Object.create() #592

wants to merge 1 commit into from

Commits on Jan 24, 2015

  1. http: replace util._extend() with Object.create() 

    `options` is never touched, so there's no need to make a copy. Anyways, a better alternative for making copies is to just `Object.create()` the object. An alternative solution is to not bother copying at all. 

This solves issues such as https://github.com/petkaantonov/urlparser/issues where the `options` object is created from a constructor.
    @jonathanong
    jonathanong committed Jan 24, 2015
    Configuration menu
    Copy the full SHA
    a4d41bd View commit details
    Browse the repository at this point in the history