Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a grammar mistake in Stream documentation #606

Closed
wants to merge 1 commit into from
Closed

Corrected a grammar mistake in Stream documentation #606

wants to merge 1 commit into from

Conversation

3674823674252
Copy link

This morning I was reading through the documentation on Streams and came across this sentence, which seemed not valid:

"If you supply as the second argument to the it will be passed to push method,.."

So I corrected it to:

"If you supply output as the second argument to the callback, it will be passed to push method,.."

That is the only change in this pull request.

@rvagg
Copy link
Member

rvagg commented Jan 26, 2015

Would you mind setting your git name to be your real name so this can be properly attributed? Presumably 3674823674252 isn't your real name. git config --global user.name "your name", then git commit --amend this one and force push it to your repo/v1.x branch and I believe that should update it.

@3674823674252
Copy link
Author

That is my intentional username.. Corrected commit, the author is set to account with more "pronounced" username (that's my other account)

@rvagg
Copy link
Member

rvagg commented Jan 26, 2015

Sorry @3674823674252, I don't want to impose a "real names policy" here, its just that some times people are unaware that they have not properly set a username. It's ultimately your choice what you're called as long as its intentional.

rvagg pushed a commit that referenced this pull request Jan 27, 2015
PR-URL: #606
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented Jan 27, 2015

landed @ 1855267 with minor commit message fix

1 similar comment
@rvagg
Copy link
Member

rvagg commented Jan 27, 2015

landed @ 1855267 with minor commit message fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants