Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for console.assert #6302

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@evanlucas
Copy link
Member

commented Apr 20, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

There were previously no tests where console.assert failed

test: add tests for console.assert
There were previously no tests where console.assert failed
@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2016

@santigimeno

This comment has been minimized.

Copy link
Member

commented Apr 20, 2016

LGTM

3 similar comments
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2016

LGTM

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2016

LGTM

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 20, 2016

LGTM

jasnell added a commit that referenced this pull request Apr 22, 2016

test: add tests for console.assert
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 22, 2016

Landed in 84ebf2b

@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2016

Thanks @jasnell!

@evanlucas evanlucas deleted the evanlucas:addconsoleasserttests branch Apr 25, 2016

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

test: add tests for console.assert
There were previously no tests where console.assert failed

PR-URL: nodejs#6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

test: add tests for console.assert
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request May 18, 2016

test: add tests for console.assert
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request May 18, 2016

test: add tests for console.assert
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@MylesBorins MylesBorins referenced this pull request May 18, 2016

Merged

v4.4.5 proposal #6824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.