Fix invalid date output with util.inspect #6504

rumkin · 2016-05-01T15:53:27Z

Checklist

tests and code linting passes
a test and/or benchmark is included
documentation is changed or added
the commit message follows commit guidelines

Description of change

util.inspect produces default string value for invalid date instead of throwing RangeError.

cjihrig · 2016-05-01T15:58:44Z

test/parallel/test-util-inspect.js

@@ -14,6 +14,7 @@ assert.equal(util.inspect(null), 'null');
 assert.equal(util.inspect(/foo(bar\n)?/gi), '/foo(bar\\n)?/gi');
 assert.equal(util.inspect(new Date('Sun, 14 Feb 2010 11:48:40 GMT')),
  new Date('2010-02-14T12:48:40+01:00').toISOString());
+assert.equal(util.inspect(new Date('')), (new Date('')).toString());


Can you use assert.strictEqual() here.

I'd make this simply:

assert.equal(util.inspect(new Date('')), 'Invalid Date');

there's no reason to create the second date object.

cjihrig · 2016-05-01T16:00:10Z

It's not a big deal because whoever lands this can fix it up but:

This should target the master branch, not v6.x.
The commit message should adhere to https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit.

jasnell · 2016-05-01T20:37:09Z

lib/util.js

+        return ctx.stylize(value.toString(), 'date');
+      } else {
+        return ctx.stylize(Date.prototype.toISOString.call(value), 'date');
+      }


just a style nit so feel free to ignore...

return ctx.stylize(Number.isNaN(value.getTime()) ? value.toString() : Date.prototype.toISOString.call(value), 'date');

... would help eliminate some minor code duplication

jasnell · 2016-05-01T20:39:42Z

semver-major because of the change in error handling (this eliminates a throw).

jasnell · 2016-05-01T20:40:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/2453/

addaleax · 2016-05-01T20:43:56Z

This restores the pre-v6.0.0 behaviour and probably aligns much more with user expectations than the current behaviour, so I would actually say it’s a bugfix. Otherwise, this means that no object containing an invalid Date object could be printed using console.log or in the repl.

cjihrig · 2016-05-01T20:55:16Z

+1 to bug fix.

jasnell · 2016-05-01T21:02:08Z

Works for me!

rumkin · 2016-05-02T10:59:26Z

@cjihrig how should I fix branch and comment now in better way?

cjihrig · 2016-05-02T13:20:10Z

Github doesn't allow you to target a new branch once a PR is made. However, master and v6.x are so similar, that I don't think it should matter in this case.

To change your commit message, you can run git commit --amend, then force push to the branch you used for this PR (in this case, v6.x).

rumkin · 2016-05-03T00:03:35Z

@cjihrig Done

cjihrig · 2016-05-03T12:38:34Z

LGTM once the comment about using assert.strictEqual() is addressed. I'd probably change the commit subsystem to just util too.

Prevent util.inspect of throwing on date object with invalid date value. It changed to output result of toString method call.

jasnell · 2016-05-06T17:46:02Z

@cjihrig ... PTAL
LGTM with the updates

Note to @rumkin : we don't get notified when new or updated commits are pushed so it can be easy to miss. Best bet is to add a comment after pushing the new commits so we get notified! :-)

cjihrig · 2016-05-06T17:58:27Z

LGTM. Thanks for the notification @jasnell

rumkin · 2016-05-07T14:58:49Z

@cjihrig @jasnell Thanks for help with my PR.

evanlucas · 2016-05-10T11:45:31Z

LGTM. Running CI one more time https://ci.nodejs.org/job/node-test-pull-request/2559/

rumkin · 2016-05-16T07:34:14Z

@cjihrig what's next? Will PR be accepted?

addaleax · 2016-05-16T09:14:00Z

@rumkin Thanks for commenting here again, sometimes things like this get a little lost.

This LGTM and I’m landing it now.

Prevent util.inspect of throwing on date object with invalid date value. It changed to output result of toString method call. PR-URL: #6504 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax · 2016-05-16T09:20:46Z

Landed in 9c33e0e. Thanks!

Prevent util.inspect of throwing on date object with invalid date value. It changed to output result of toString method call. PR-URL: #6504 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins · 2016-06-02T00:48:29Z

@nodejs/lts is this something we want to backport?

addaleax · 2016-06-02T00:53:23Z

@thealphanerd Just fyi, this was prompted by a change that came with the v8 changes in v6.0.0 and should be a no-op in the previous versions.

…v6.1. nodejs/node#6504

cjihrig mentioned this pull request May 1, 2016

fix throwing RangeError on invalid date output #6469

Closed

4 tasks

cjihrig reviewed May 1, 2016
View reviewed changes

mscdex added the util Issues and PRs related to the built-in util module. label May 1, 2016

jasnell added error-handling semver-major PRs that contain breaking changes and should be released in the next major version. labels May 1, 2016

jasnell reviewed May 1, 2016
View reviewed changes

jasnell removed the semver-major PRs that contain breaking changes and should be released in the next major version. label May 1, 2016

Fishrock123 changed the title ~~Fix invalid date output with util.ispect~~ Fix invalid date output with util.inspect May 2, 2016

rumkin force-pushed the v6.x branch from 1ff9c6f to e5018db Compare May 3, 2016 00:02

util: fix invalid date output with util.inspect

f3496d3

Prevent util.inspect of throwing on date object with invalid date value. It changed to output result of toString method call.

rumkin force-pushed the v6.x branch from e5018db to f3496d3 Compare May 5, 2016 23:43

addaleax closed this May 16, 2016

evanlucas mentioned this pull request May 17, 2016

2016-05-17, Version 6.2.0 (Stable) #6810

Merged

MylesBorins added the lts-watch-v4.x label Jun 2, 2016

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Jun 2, 2016

ljharb added a commit to ljharb/es-to-primitive that referenced this pull request Aug 27, 2017

[Tests] avoid util.inspect bug with new Date(NaN) on node v6.0 and …

01cebe3

…v6.1. nodejs/node#6504

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix invalid date output with util.inspect #6504

Fix invalid date output with util.inspect #6504

rumkin commented May 1, 2016 •

edited

cjihrig May 1, 2016

jasnell May 1, 2016

cjihrig commented May 1, 2016

jasnell May 1, 2016

jasnell commented May 1, 2016

jasnell commented May 1, 2016

addaleax commented May 1, 2016 •

edited

cjihrig commented May 1, 2016

jasnell commented May 1, 2016

rumkin commented May 2, 2016

cjihrig commented May 2, 2016

rumkin commented May 3, 2016

cjihrig commented May 3, 2016

jasnell commented May 6, 2016

cjihrig commented May 6, 2016

rumkin commented May 7, 2016

evanlucas commented May 10, 2016

rumkin commented May 16, 2016

addaleax commented May 16, 2016

addaleax commented May 16, 2016

MylesBorins commented Jun 2, 2016

addaleax commented Jun 2, 2016

Fix invalid date output with util.inspect #6504

Fix invalid date output with util.inspect #6504

Conversation

rumkin commented May 1, 2016 • edited

Checklist

Description of change

cjihrig May 1, 2016

Choose a reason for hiding this comment

jasnell May 1, 2016

Choose a reason for hiding this comment

cjihrig commented May 1, 2016

jasnell May 1, 2016

Choose a reason for hiding this comment

jasnell commented May 1, 2016

jasnell commented May 1, 2016

addaleax commented May 1, 2016 • edited

cjihrig commented May 1, 2016

jasnell commented May 1, 2016

rumkin commented May 2, 2016

cjihrig commented May 2, 2016

rumkin commented May 3, 2016

cjihrig commented May 3, 2016

jasnell commented May 6, 2016

cjihrig commented May 6, 2016

rumkin commented May 7, 2016

evanlucas commented May 10, 2016

rumkin commented May 16, 2016

addaleax commented May 16, 2016

addaleax commented May 16, 2016

MylesBorins commented Jun 2, 2016

addaleax commented Jun 2, 2016

rumkin commented May 1, 2016 •

edited

addaleax commented May 1, 2016 •

edited