doc: note that v8 options work with both dashes and underscores #6532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,6 +111,9 @@ Process v8 profiler output generated using the v8 option `--prof`. | |||
|
|
|||
| Print v8 command line options. | |||
|
|
|||
| Note: v8 options allow words to be separated by both dashes (`-`) or underscores (`_`). | |||
|
TIL, LGTM minus the line wrap. |
Fishrock123
force-pushed
the
doc-v8-options-dash-underscore
branch
from
d698f28
to
6145681
Compare
|
@benjamingr & @jasnell lgty? |
|
Yea, go right ahead :) |
| Note: v8 options allow words to be separated by both dashes (`-`) or underscores | ||
| (`_`). | ||
|
|
||
| For example, `--stack-trace-limit` is equivalent to `--stack_trace_limit`. |
There was a problem hiding this comment.
nit: it's likely not worth noting but --stack-trace_limit and --stack_trace-limit are also equivalent.
|
Looks fine. |
This adds docs to the man page and online cli docs that v8 options can be used with either dashes or underscores. Refs: nodejs#6377 (comment) PR-URL: nodejs#6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
force-pushed
the
doc-v8-options-dash-underscore
branch
from
6145681
to
4b107d0
Compare
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
This adds docs to the man page and online cli docs that v8 options can be used with either dashes or underscores. Refs: #6377 (comment) PR-URL: #6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
PR-URL: #6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
see #6377 (comment)
This adds docs to the man page and online cli docs that v8 options can be used with either.
r=@nodejs/documentation