Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unmark test-http-regr-gh-2928 as flaky #6540

Closed
wants to merge 1 commit into from
Closed

test: unmark test-http-regr-gh-2928 as flaky #6540

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 3, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

@Trott
test: unmark test-http-regr-nodejsgh-2928 as flaky
01f60a0 
The flakiness issue for test-http-regr-nodejsgh-2928 on SmartOS was resolved
in late February in nodejs#5454. This
change removes its flaky designation in sequential.status.
@Trott Trott added the test Issues and PRs related to the tests. label May 3, 2016
@Trott
Copy link
Member Author

Trott commented May 3, 2016

Stress test on 32-bit SmartOS: https://ci.nodejs.org/job/node-stress-single-test/685/

Stress test on 64-bit SmartOS: https://ci.nodejs.org/job/node-stress-single-test/686/

CI: https://ci.nodejs.org/job/node-test-pull-request/2474/

@mscdex mscdex added http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. labels May 3, 2016
@jasnell
Copy link
Member

jasnell commented May 3, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request May 5, 2016
@Trott
test: unmark test-http-regr-nodejsgh-2928 as flaky
330ea76 
The flakiness issue for test-http-regr-nodejsgh-2928 on SmartOS was resolved
in late February in nodejs#5454. This
change removes its flaky designation in sequential.status.

PR-URL: nodejs#6540
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 5, 2016

Landed in 330ea76

@Trott Trott closed this May 5, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@Trott @evanlucas
test: unmark test-http-regr-gh-2928 as flaky
8c434e6 
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
@MylesBorins
Copy link
Member

@Trott lts?

@Trott
Copy link
Member Author

Trott commented Jun 2, 2016

@thealphanerd Yes.

MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@Trott
test: unmark test-http-regr-gh-2928 as flaky
a27439a 
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@Trott
test: unmark test-http-regr-gh-2928 as flaky
34b61d6 
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott @MylesBorins
test: unmark test-http-regr-gh-2928 as flaky
c1b62eb 
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
test: unmark test-http-regr-gh-2928 as flaky
9e8addd 
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: unmark test-http-regr-gh-2928 as flaky
39fbc18 
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: unmark test-http-regr-gh-2928 as flaky
3aef9b8 
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in #5454. This
change removes its flaky designation in sequential.status.

PR-URL: #6540
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the smart branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Trott @jasnell @MylesBorins @mscdex