doc: correct anchors for buffer.md #6542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -403,7 +403,7 @@ The `size` must be less than or equal to the value of | |||
| be created if a `size` less than or equal to 0 is specified. | |||
|
|
|||
| If `fill` is specified, the allocated `Buffer` will be initialized by calling | |||
| `buf.fill(fill)`. See [`buf.fill()`][] for more information. | |||
| `buf.fill(fill)`. See [`buf.fill(0)`][] for more information. | |||
There was a problem hiding this comment.
Could you change only the href here, not the text itself? I think that makes more sense.
the `buf.fill()` and `Buffer#indexOf` don't have correctly anchors
|
LGTM |
1 similar comment
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
May 6, 2016
the `buf.fill()` and `Buffer#indexOf` don't have correctly anchors PR-URL: #6542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in b8573d0. Thank you! |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
the `buf.fill()` and `Buffer#indexOf` don't have correctly anchors PR-URL: #6542 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
this is not landing cleanly on v4.x-staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
the
buf.fill()andBuffer#indexOfdon't have correctly anchors