deps: upgrade libuv to 1.9.1 #6796

saghul · 2016-05-16T22:46:37Z

Checklist

the commit message follows commit guidelines

Affected core subsystem(s)

deps, libuv

Description of change

Fixes: #4002
Fixes: #5384
Fixes: #6563
Refs: #2680 (comment)

saghul · 2016-05-16T22:47:20Z

/cc @nodejs/collaborators

MylesBorins · 2016-05-16T22:53:43Z

ci: https://ci.nodejs.org/job/node-test-pull-request/2670/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/271/

MylesBorins · 2016-05-16T22:56:50Z

deps/uv/src/unix/fs.c

@@ -383,7 +392,7 @@ static ssize_t uv__fs_pathmax_size(const char* path) {
 #if defined(PATH_MAX)
    return PATH_MAX;
 #else
-    return 4096;
+#error "PATH_MAX undefined in the current platform"


It is worth noting that this change will make Node unable to compile on platforms that do not have PATH_MAX defined

/cc @nodejs/security @bnoordhuis

If we run into such a platform we'll send them a cake as an apology. 😎

Indeed, I think this is a necessary change, although I know @bnoordhuis had mixed feelings. Mostly wanted to make sure it was clear from the beginning so there were no surprises
👼

The cake shouldn't exceed a specific maximum size.

The cake isn't a lie?

the specific maximum cake size will vary depending on whether you're running OSX or Linux. And it may or may not be fully covered in frosting by the time it's delivered. Windows users don't get cake.

There may be no frosting at all, depending on whether you called process.exit() too soon.

The cake probably won't arrive on time if you're using raspberry pi.

saghul · 2016-05-17T00:06:03Z

The CI is 💚 except for some seemingly unrelated EAGAIN failures on one SmartOS machine and FreeBSD.

I'm not sure how to interpret the citgm results, they all seem to fail because yards couldn't be installed?

jasnell · 2016-05-17T00:10:28Z

The yargs failure is hopefully just a hiccup. Everything else appears to be fine.

eljefedelrodeodeljefe · 2016-05-17T00:17:33Z

Couldn't find the entry, but: yargs were the first ones to move because of #6456

MylesBorins · 2016-05-17T00:19:50Z

yargs failure is due to v4.7.1 tag not being published to github.

cjihrig · 2016-05-17T00:20:58Z

Rubber stamp LGTM

jasnell · 2016-05-17T00:21:54Z

LGTM

MylesBorins · 2016-05-17T00:23:37Z

LGTM

jbergstroem · 2016-05-17T00:23:55Z

LGTM

Fixes: nodejs#4002 Fixes: nodejs#5384 Fixes: nodejs#6563 Refs: nodejs#2680 (comment) PR-URL: nodejs#6796 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com>

saghul · 2016-05-17T00:29:36Z

Landed! 🎉

jasnell · 2016-05-17T00:31:37Z

Ok on landing but probably should have given it at least a day ;-) .. two hours is a bit quick even if everything looks good

saghul · 2016-05-17T07:17:56Z

Sorry about that! It was super late here and I was under the impression
that you all wanted this one badly for the Windows CLI fix, so I wanted to
give you as much time as possible before the Tuesday release.

Duly noted!
On May 17, 2016 01:32, "James M Snell" notifications@github.com wrote:

Ok on landing but probably should have given it at least a day ;-) .. two
hours is a bit quick even if everything looks good

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#6796 (comment)

orangemocha · 2016-05-17T11:39:53Z

@nodejs/release please include this in the next v6.x release. It's a semver-patch change. 😃

evanlucas · 2016-05-17T13:05:57Z

@orangemocha thanks. Will make sure we get it in.

Fixes: #4002 Fixes: #5384 Fixes: #6563 Refs: #2680 (comment) PR-URL: #6796 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com>

- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna Henningsen) [#6511](#6511) - **child_process**: use /system/bin/sh on android (Ben Noordhuis) [#6745](#6745) - **deps**: - upgrade npm to 3.8.9 (Rebecca Turner) [#6664](#6664) - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh) [#6572](#6572) - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) [#6796](#6796) - Intl: ICU 57 bump (Steven R. Loomis) [#6088](#6088) - **repl**: - copying tabs shouldn't trigger completion (Eugene Obrezkov) [#5958](#5958) - exports `Recoverable` (Blake Embrey) [#3488](#3488) - **src**: add O_NOATIME constant (Rich Trott) [#6492](#6492) - **src,module**: add --preserve-symlinks command line flag (James M Snell) [#6537](#6537) - **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen) [#6683](#6683)

- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna Henningsen) [#6511](#6511) - **child_process**: use /system/bin/sh on android (Ben Noordhuis) [#6745](#6745) - **deps**: - upgrade npm to 3.8.9 (Rebecca Turner) [#6664](#6664) - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh) [#6572](#6572) - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) [#6796](#6796) - Intl: ICU 57 bump (Steven R. Loomis) [#6088](#6088) - **repl**: - copying tabs shouldn't trigger completion (Eugene Obrezkov) [#5958](#5958) - exports `Recoverable` (Blake Embrey) [#3488](#3488) - **src**: add O_NOATIME constant (Rich Trott) [#6492](#6492) - **src,module**: add --preserve-symlinks command line flag (James M Snell) [#6537](#6537) - **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen) [#6683](#6683) As of this release the 6.X line now includes 64-bit binaries for Linux on Power Systems running in big endian mode in addition to the existing 64-bit binaries for running in little endian mode. PR-URL: #6810

lucab · 2016-05-28T17:34:30Z

General question: is v4.x also going to get these libuv updates? It looks like 1.8.0 was the last one to get backported, and I'm not sure what's the policy there.

bnoordhuis · 2016-05-28T17:36:43Z

@lucab Yes, v4 will get the updates eventually. We've been holding off the upgrade because of possible regressions. ('Regressions' is perhaps not the right word. It's complicated.)

lucab · 2016-05-28T22:25:17Z

For reference, I've also been pointed to #6806 where policy discussion is happening.

Fixes: nodejs#4002 Fixes: nodejs#5384 Fixes: nodejs#6563 Refs: nodejs#2680 (comment) PR-URL: nodejs#6796 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com>

Fixes: #4002 Fixes: #5384 Fixes: #6563 Refs: #2680 (comment) PR-URL: #6796 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com>

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * backport 9c927d0f01 from V8 upstream (Myles Borins) #7451 * cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Fixes: #4002 Fixes: #5384 Fixes: #6563 Refs: #2680 (comment) PR-URL: #6796 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com>

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

Notable Changes: Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post mortem data to improve object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **crypto**: * update root certificates (Ben Noordhuis) #7363 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label May 16, 2016

MylesBorins reviewed May 16, 2016
View reviewed changes

BarryThePenguin mentioned this pull request May 16, 2016

Can't select change type with arrow keys commitizen/cz-cli#10

Closed

saghul force-pushed the uv-upgrade branch from 59ba222 to 9b9aed1 Compare May 17, 2016 00:28

saghul force-pushed the uv-upgrade branch from 9b9aed1 to b78a704 Compare May 17, 2016 00:28

saghul closed this May 17, 2016

saghul merged commit b78a704 into nodejs:master May 17, 2016

evanlucas mentioned this pull request May 17, 2016

2016-05-17, Version 6.2.0 (Stable) #6810

Merged

MylesBorins added the lts-watch-v4.x label Jun 2, 2016

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Jul 11, 2016

MylesBorins mentioned this pull request Jul 12, 2016

v4.5.0 proposal #7688

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: upgrade libuv to 1.9.1 #6796

deps: upgrade libuv to 1.9.1 #6796

saghul commented May 16, 2016

saghul commented May 16, 2016

MylesBorins commented May 16, 2016

MylesBorins May 16, 2016

saghul May 16, 2016

MylesBorins May 16, 2016

jasnell May 16, 2016

mscdex May 17, 2016

jasnell May 17, 2016 •

edited

mscdex May 17, 2016

jasnell May 17, 2016

saghul commented May 17, 2016

jasnell commented May 17, 2016

eljefedelrodeodeljefe commented May 17, 2016

MylesBorins commented May 17, 2016

cjihrig commented May 17, 2016

jasnell commented May 17, 2016

MylesBorins commented May 17, 2016

jbergstroem commented May 17, 2016

saghul commented May 17, 2016

jasnell commented May 17, 2016

saghul commented May 17, 2016

orangemocha commented May 17, 2016

evanlucas commented May 17, 2016

lucab commented May 28, 2016

bnoordhuis commented May 28, 2016

lucab commented May 28, 2016 •

edited

deps: upgrade libuv to 1.9.1 #6796

deps: upgrade libuv to 1.9.1 #6796

Conversation

saghul commented May 16, 2016

Checklist

Affected core subsystem(s)

Description of change

saghul commented May 16, 2016

MylesBorins commented May 16, 2016

MylesBorins May 16, 2016

Choose a reason for hiding this comment

saghul May 16, 2016

Choose a reason for hiding this comment

MylesBorins May 16, 2016

Choose a reason for hiding this comment

jasnell May 16, 2016

Choose a reason for hiding this comment

mscdex May 17, 2016

Choose a reason for hiding this comment

jasnell May 17, 2016 • edited

Choose a reason for hiding this comment

mscdex May 17, 2016

Choose a reason for hiding this comment

jasnell May 17, 2016

Choose a reason for hiding this comment

saghul commented May 17, 2016

jasnell commented May 17, 2016

eljefedelrodeodeljefe commented May 17, 2016

MylesBorins commented May 17, 2016

cjihrig commented May 17, 2016

jasnell commented May 17, 2016

MylesBorins commented May 17, 2016

jbergstroem commented May 17, 2016

saghul commented May 17, 2016

jasnell commented May 17, 2016

saghul commented May 17, 2016

orangemocha commented May 17, 2016

evanlucas commented May 17, 2016

lucab commented May 28, 2016

bnoordhuis commented May 28, 2016

lucab commented May 28, 2016 • edited

jasnell May 17, 2016 •

edited

lucab commented May 28, 2016 •

edited