installer: don't install node_internals.h #6913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
install
mscdex
added
the
c++
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
bnoordhuis
force-pushed
the
installer-omit-internals
branch
from
5f79cd2
to
b0e8a42
Compare
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
As the name suggests, it's for internal use only, so don't install it. Including it in an add-on doesn't work because the file depends on other header files that are not installed. Adding it to the install list appears to have been an oversight in commit 32478ac ("build: unix install node and dep library headers"). PR-URL: #6913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name suggests, it's for internal use only, so don't install it.
Including it in an add-on doesn't work because the file depends on other
header files that are not installed.
Adding it to the install list appears to have been an oversight in
commit 32478ac ("build: unix install node and dep library headers").
(And that's why we have code reviews.)
No CI, it doesn't exercise the installer.