test: fix spawn on windows #7049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
child_process
| @@ -3,7 +3,13 @@ const cp = require('child_process'); | |||
| const common = require('../common'); | |||
| const assert = require('assert'); | |||
|
|
|||
| const p = cp.spawn('echo'); | |||
| const opts = {}; | |||
There was a problem hiding this comment.
Could you just do const opts = {shell: common.isWindows};
|
LGTM. How was this working on the CI machines? |
|
@cjihrig Probably they have some sort of mingw/cygwin/etc. environment installed? I noticed it while running tests on a local Windows 7 VM that doesn't have any of that kind of stuff installed. |
mscdex
force-pushed
the
test-fix-win32-child-process-flush-stdio
branch
from
cddfef0
to
883f253
Compare
|
Windows CI machines have Git for Windows installed, and use the executables provided by that. There should be a few more tools required to run the tests, I once compiled a list but it should be quite outdated now: https://github.com/nodejs/node/wiki/Installation#building-on-windows (bottom of that section). It's good to see one of those dependencies go away, LGTM. |
2 tasks
mscdex
force-pushed
the
test-fix-win32-child-process-flush-stdio
branch
2 times, most recently
from
94cd580
to
b04f1ba
Compare
|
CI one last time before landing: https://ci.nodejs.org/job/node-test-pull-request/2942/ |
|
LGTM |
Most Windows systems do not have an external `echo` program installed, so any attempts to spawn `echo` as a child process will fail with `ENOENT`. This commit forces the use of the built-in `echo` provided by `cmd.exe`. PR-URL: nodejs#7049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
mscdex
force-pushed
the
test-fix-win32-child-process-flush-stdio
branch
from
b04f1ba
to
e18a926
Compare
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
Most Windows systems do not have an external `echo` program installed, so any attempts to spawn `echo` as a child process will fail with `ENOENT`. This commit forces the use of the built-in `echo` provided by `cmd.exe`. PR-URL: #7049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
Most Windows systems do not have an external `echo` program installed, so any attempts to spawn `echo` as a child process will fail with `ENOENT`. This commit forces the use of the built-in `echo` provided by `cmd.exe`. PR-URL: #7049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Most Windows systems do not have an external `echo` program installed, so any attempts to spawn `echo` as a child process will fail with `ENOENT`. This commit forces the use of the built-in `echo` provided by `cmd.exe`. PR-URL: #7049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Most Windows systems do not have an external `echo` program installed, so any attempts to spawn `echo` as a child process will fail with `ENOENT`. This commit forces the use of the built-in `echo` provided by `cmd.exe`. PR-URL: #7049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Most Windows systems do not have an external `echo` program installed, so any attempts to spawn `echo` as a child process will fail with `ENOENT`. This commit forces the use of the built-in `echo` provided by `cmd.exe`. PR-URL: #7049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Most Windows systems do not have an external `echo` program installed, so any attempts to spawn `echo` as a child process will fail with `ENOENT`. This commit forces the use of the built-in `echo` provided by `cmd.exe`. PR-URL: #7049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
@thealphanerd While this landed cleanly on V4 it doesn't work and the test case still fails there. The shell:true option only exists in V6 and later. I'm submitting a separate PR to implement the fix differently in that branch |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Most Windows systems do not have an external
echoprogram installed, so any attempts to spawnechoas a child process will fail withENOENT. This commit forces the use of the built-inechoprovided bycmd.exe.