buffer: expose internals on binding #770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `internal` object and expose functions directly on binding. This makes possible to simply use internal functions in other builtin modules.
|
The point of the approach was to make sure code that could |
|
@trevnorris don't we have existing bindings that are strict with their arguments that are exposed in this way? If we do then this LGTM but if we don't already have an example to follow then I'm not enthusiastic. |
|
@rvagg not sure what you are talking about. This is consistent with how other bindings are implemented |
|
@rvagg ping. do you still have objections to this? |
|
LGTM |
vkurchatkin
added a commit
that referenced
this pull request
Feb 11, 2015
Remove internal object and expose functions directly on binding. This makes possible to simply use internal functions in other builtin modules. PR-URL: #770 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 36a7795. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
internalobject and expose functions directly on binding.This makes possible to simply use internal functions in other builtin
modules.
R=@trevnorris