win,msi: fix inclusion of translations #7798
Conversation
joaocgreis
added
windows
mscdex
changed the title
| @@ -54,9 +54,12 @@ | |||
| </WixExtension> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <!-- <EmbeddedResource Include="i18n\de-de.wxl" /> --> | |||
| <EmbeddedResource Include="i18n\en-us.wxl" /> | |||
| <!-- | |||
There was a problem hiding this comment.
does this not comment out all but english?
There was a problem hiding this comment.
what's the plan on releasing with the translations?
There was a problem hiding this comment.
@evanlucas yes, this is supposed to be commented for now. The translations are not yet active, the installer only has english.
@fhemberger is there a plan to release with translations? Are we just waiting for more translations to arrive? On the build side, we use the stable release of WiX, so english and german are the only languages supported. The WiX website recommends not to use the weekly versions in production, but we could perhaps add just the translation files to the release version, if it works.
There was a problem hiding this comment.
@joaocgreis the issue there is that WiX guys are going to make a new release only for the next Visual Studio release so it could take time
There was a problem hiding this comment.
@joaocgreis @fhemberger is using weekly build of WiX a viable option for building node installer?
There was a problem hiding this comment.
@piccoloaiutante I'm a little hesitant to use a weekly build because the WiX website says not to, and breaking the MSI is something that would cause major pain for users. But I'd be willing to give it a try, provided that we build release candidates for a few versions and get them well tested. Using the translations with the release version still sounds better.
Do we have a plan for when to start shipping with this?
There was a problem hiding this comment.
@joaocgreis i don't have any visibility on when shipping localized installer
|
I have a very little experience in all of this.. cc @piccoloaiutante might help. |
|
If those translations are not even supported, I think I would prefer to back them out of the 6.3.1 proposal, at least until we figure this out. Thanks! |
|
@evanlucas sounds good, for end users it's the same as it is now. |
|
@nodejs/platform-windows can you please review? This will fix the nightlies. |
|
@pmq20 @dead-horse @yorkie @fhemberger @XadillaX @mcollina @rvagg you submitted and reviewed the original PRs, this should be an easy review for you. Can you please take a look to get the releases unbroken and the nightlies flowing again? |
|
LGTM |
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> PR-URL: #7798
|
CI: https://ci.nodejs.org/job/node-test-pull-request/3478/ (freebsd failure unrelated) Landed in c9e670e |
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> PR-URL: #7798
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> PR-URL: #7798
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> PR-URL: #7798
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> PR-URL: #7798
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Build, MSI.
Description of change
This PR fixes two issues with the MSI:
nodemsi.wixproj, so building the MSI is currently broken when using a release version of WiX.nodemsi.wixprojcc @nodejs/build @nodejs/platform-windows @pmq20 @mcollina