repl: disable Ctrl+C support on win32 for now #7977
Conversation
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of evaluated expressions. This is a temporary measure, since the underlying problem is very likely not related to this specific feature. Ref: nodejs#7837
addaleax
added
repl
|
Oy, this is unfortunate but LGTM as a temporary measure. /cc @nodejs/platform-windows |
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM, thanks for the env var! |
|
oh! mentioning the env var reminded me... is the intent to keep the env var undocumented and temporary as well? If not, then this should also add documentation to printHelp and docs. |
|
@jasnell No, keeping it uncodumented is exactly the plan (or at least what I am having in mind). I thought about getting fancy with underscores or something, but that just seemed weird for env vars. |
|
+1 awesome. That's what I suspected but wanted to clarify. It may be worthwhile adding a code comment to that effect in case someone else comes across it and wonders. |
|
@jasnell Done! :) |
|
Thank you! :-) |
|
New CI run just to be safe: https://ci.nodejs.org/job/node-test-pull-request/3571/ |
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of evaluated expressions. This is a temporary measure, since the underlying problem is very likely not related to this specific feature. Ref: #7837 PR-URL: #7977 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
|
Landed in f59b888! |
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of evaluated expressions. This is a temporary measure, since the underlying problem is very likely not related to this specific feature. Ref: #7837 PR-URL: #7977 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
|
@addaleax does this need to be backported? |
|
No. :) |
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
repl
Description of change
Disable Windows support for interrupting REPL commands using Ctrl+C by default, because the switches from console raw mode and back have been interfering with printing the results of
evaluated expressions.
This is a temporary measure, since the underlying problem is very likely not related to this specific feature.
Ref: #7837
/cc @joaocgreis