test: fix test-tls-getcipher #853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the commit line have a "test:" prefix instead of "tls:"? |
|
I was unsure about that, you're probably right. |
The test blindly assumes that the default cipher suite supports RC4 ciphers. This corrects the case where RC4 might not be available in the default ciphers by setting the client to use the same suite as the server.
silverwind
force-pushed
the
fix-test-tls-getcipher
branch
from
f6a63ed
to
d5ac246
Compare
bnoordhuis
pushed a commit
that referenced
this pull request
Feb 15, 2015
The test blindly assumes that the default cipher suite supports RC4 ciphers. This corrects the case where RC4 might not be available in the default ciphers by setting the client to use the same suite as the server. PR-URL: #853 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks Roman, landed in 30e340a. I wouldn't have minded if you had made it part of the original pull request but this way is fine too. |
This was referenced Nov 29, 2023
This was referenced Nov 30, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #826.
cc: @bnoordhuis