Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test child process send utf8 #8594

Conversation

Projects
None yet
7 participants
@JonathanPrince
Copy link
Contributor

commented Sep 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • changed var to const where appropriate
  • updated callback to use arrow function syntax
test: update test child process send utf8
change var to const
use arrow function in callback
use strict equal

@JonathanPrince JonathanPrince force-pushed the JonathanPrince:update_test_child_process_send_utf8 branch to 20f281a Sep 17, 2016

@cjihrig
Copy link
Contributor

left a comment

LGTM

@addaleax
Copy link
Member

left a comment

LGTM with a green CI

@lpinca

lpinca approved these changes Sep 19, 2016

Copy link
Member

left a comment

LGTM

@jasnell
Copy link
Member

left a comment

LGTM

@jasnell

This comment has been minimized.

@Trott Trott force-pushed the nodejs:master branch to c5ce7f4 Sep 21, 2016

jasnell added a commit that referenced this pull request Sep 22, 2016

test: update test/parallel/test-child-process-send-utf8.js
change var to const
use arrow function in callback
use strict equal

PR-URL: #8594
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Landed in eb31c79. Thank you!

@jasnell jasnell closed this Sep 22, 2016

jasnell added a commit that referenced this pull request Sep 29, 2016

test: update test/parallel/test-child-process-send-utf8.js
change var to const
use arrow function in callback
use strict equal

PR-URL: #8594
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

test: update test/parallel/test-child-process-send-utf8.js
change var to const
use arrow function in callback
use strict equal

PR-URL: #8594
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.