tls: improve createSecureContext in _tls_common #8781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, |
|
@mscdex Thanks for this tip, and I have followed your suggestion and replace all |
|
The functional array methods are also slow unfortunately. What about just pulling the variable declaration out to the top of the function? |
yorkie
force-pushed
the
tls/improve-createSecureContext
branch
from
a33e722
to
796613e
Compare
|
Done @mscdex :) |
|
LGTM if CI is ok with it: https://ci.nodejs.org/job/node-test-pull-request/4280/ |
- this shares the iterator variable `i` expictly. - this converts some var to const. PR-URL: nodejs#8781 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
yorkie
force-pushed
the
tls/improve-createSecureContext
branch
from
796613e
to
86a6e57
Compare
yorkie
added a commit
that referenced
this pull request
Sep 28, 2016
- this shares the iterator variable `i` expictly. - this converts some var to const. PR-URL: #8781 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
CI is green and Landed in f4d7abf :) |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
- this shares the iterator variable `i` expictly. - this converts some var to const. PR-URL: #8781 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
- this shares the iterator variable `i` expictly. - this converts some var to const. PR-URL: #8781 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tls
Description of change
The createSecureContext function is using let in for loop, to keep coding
consistence inside that function, update to use let/const, too.