Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
tools: avoid let in for loops #9049
referenced this pull request
Oct 12, 2016
Thanks for the PR! This generally looks good to me, aside from one small change.
So it looks like you will need to add an entry into the
You can check http://eslint.org/docs/developer-guide/working-with-rules#runtime-rules for more details
edit: you may want to alternatively put it in
once the rule is added you will notice TONS of failures in our test / benchmark directories. You will likely want to fix all of those in a separate commit. Once you have done that you will want to rebase the rule to after the changes, so that the repo will always be in a working state.
this will give you a list of commits, you can then move the commits around in that list, save, and close. This will edit the history
You will likely want to compile and test locally to make sure it works.
Let me know if you have any questions
Only change I'd want to see is reporting the right column, although honestly, if that is onerous or controversial, this can land as is.