New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: name anonymous functions #9054

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@maasencioh
Contributor

maasencioh commented Oct 12, 2016

Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@maasencioh maasencioh force-pushed the maasencioh:name_http_agent branch to 2e433da Oct 12, 2016

@maasencioh maasencioh changed the title from http_agent: name anonymous functions to http: name anonymous functions Oct 12, 2016

@@ -91,7 +91,7 @@ Agent.defaultMaxSockets = Infinity;
Agent.prototype.createConnection = net.createConnection;
// Get the key for a given set of request options
Agent.prototype.getName = function(options) {
Agent.prototype.getName = function getName(options) {

This comment has been minimized.

@Fishrock123

Fishrock123 Oct 12, 2016

Member

@Raynos is this good enough or would something like getAgentName be better?

This comment has been minimized.

@Raynos

Raynos Oct 13, 2016

Contributor

Generally in flamegraphs you see fileName & function name, the two together help a bunch.

In a heapsnapshot you only see function name, however a heap snapshot does show whom holds a reference to the function, if a function is referenced from a class then that anchor point makes it easy to find.

I think having any kind of name at all is great. Having a unique name like Agent_getName does improve it slightly but that might get really annoying for coding style / redundency.

@lpinca

lpinca approved these changes Oct 12, 2016

LGTM

@jasnell

LGTM

@lpinca

This comment has been minimized.

@maasencioh

This comment has been minimized.

Contributor

maasencioh commented Oct 17, 2016

I'm not sure that that test in smartos fail it's related with the change, but there's any way to be sure?

@lpinca

This comment has been minimized.

Member

lpinca commented Oct 17, 2016

not ok 138 parallel/test-async-wrap-check-providers
# TIMEOUT

Not related to this change :)

@rvagg rvagg force-pushed the nodejs:master branch 2 times, most recently to 83c7a88 Oct 18, 2016

@jasnell jasnell self-assigned this Oct 18, 2016

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions
Ref: #8913
PR-URL: #9054
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 18, 2016

Landed in cb45374

@jasnell jasnell closed this Oct 18, 2016

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions
Ref: #8913
PR-URL: #9054
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@maasencioh maasencioh deleted the maasencioh:name_http_agent branch Oct 18, 2016

jasnell added a commit that referenced this pull request Oct 19, 2016

http: name anonymous functions
Ref: #8913
PR-URL: #9054
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment