Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: name anonymous functions #9055

Closed
wants to merge 5 commits into from
Closed

http: name anonymous functions #9055

wants to merge 5 commits into from

Conversation

maasencioh
Copy link
Contributor

Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Oct 12, 2016
@lpinca
Copy link
Member

lpinca commented Oct 12, 2016

@maasencioh subsystem is simply http.

@maasencioh
Copy link
Contributor Author

@lpinca ok thanks!

@maasencioh maasencioh changed the title http_client: name anonymous functions http: name anonymous functions Oct 12, 2016
lpinca
lpinca reviewed Oct 12, 2016
View reviewed changes
lib/_http_client.js
@@ -581,7 +581,7 @@ function onSocketNT(req, socket) {
}
}

ClientRequest.prototype._deferToConnect = function(method, arguments_, cb) {
ClientRequest.prototype._deferToConnect = function _deferToConnect(method, arguments_, cb) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: long line.

@maasencioh maasencioh mentioned this pull request Oct 13, 2016
Closed
1 task
@fhinkel
Copy link
Member

fhinkel commented Oct 13, 2016

Thanks! LGTM pending green CI (I would start it but I get a time out).

jasnell
jasnell approved these changes Oct 14, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Oct 14, 2016

LGTM.

CI: https://ci.nodejs.org/job/node-test-pull-request/4519/

lpinca
lpinca approved these changes Oct 14, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maasencioh
Copy link
Contributor Author

The same question here, I don't think that the freebsd break it's related with the current changes, but how can I be sure?

@lpinca
Copy link
Member

lpinca commented Oct 17, 2016 •
edited

You can check the logs here https://ci.nodejs.org/job/node-test-commit-freebsd/4823/nodes=freebsd11-x64/console to see what failed. In this case:

not ok 1161 parallel/test-tick-processor-unknown
# TIMEOUT

Not something to worry about.

@maasencioh
Copy link
Contributor Author

Thanks @lpinca, I read it but see a red flag makes me panic 😛

@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
@jasnell jasnell self-assigned this Oct 18, 2016
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_client
23d6e1f 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_incoming
239ff06 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_outgoing
2ccf601 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_server
02c3c20 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in http
accf410 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 18, 2016

Landed in 23d6e1f...accf410

@jasnell jasnell closed this Oct 18, 2016
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_client
0eb4826 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_incoming
5a2b714 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_outgoing
86c4a5c 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_server
9b178ef 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 18, 2016
@maasencioh @jasnell
http: name anonymous functions in http
5589ab4 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@maasencioh maasencioh deleted the name_http_client branch October 18, 2016 23:47
jasnell pushed a commit that referenced this pull request Oct 19, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_client
ec17e76 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 19, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_incoming
fa035ad 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 19, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_outgoing
ffa5c9e 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 19, 2016
@maasencioh @jasnell
http: name anonymous functions in _http_server
73a8d3b 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 19, 2016
@maasencioh @jasnell
http: name anonymous functions in http
1791500 
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 17, 2016
Closed
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 9, 2017
@MylesBorins MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

@jasnell jasnell

Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@maasencioh @lpinca @fhinkel @targos @jasnell @MylesBorins @nodejs-github-bot