New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: name anonymous functions #9055

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@maasencioh
Contributor

maasencioh commented Oct 12, 2016

Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@lpinca

This comment has been minimized.

Member

lpinca commented Oct 12, 2016

@maasencioh subsystem is simply http.

@maasencioh maasencioh force-pushed the maasencioh:name_http_client branch Oct 12, 2016

@maasencioh

This comment has been minimized.

Contributor

maasencioh commented Oct 12, 2016

@lpinca ok thanks!

@maasencioh maasencioh changed the title from http_client: name anonymous functions to http: name anonymous functions Oct 12, 2016

lib/_http_client.js Outdated
@@ -581,7 +581,7 @@ function onSocketNT(req, socket) {
}
}
ClientRequest.prototype._deferToConnect = function(method, arguments_, cb) {
ClientRequest.prototype._deferToConnect = function _deferToConnect(method, arguments_, cb) {

This comment has been minimized.

@lpinca

lpinca Oct 12, 2016

Member

Nit: long line.

@maasencioh maasencioh force-pushed the maasencioh:name_http_client branch to 0f3a691 Oct 13, 2016

@maasencioh maasencioh referenced this pull request Oct 13, 2016

Closed

http: name anonymous functions in _http_server #9060

1 of 1 task complete
@fhinkel

This comment has been minimized.

Member

fhinkel commented Oct 13, 2016

Thanks! LGTM pending green CI (I would start it but I get a time out).

@jasnell

LGTM

@targos

This comment has been minimized.

Member

targos commented Oct 14, 2016

@lpinca

lpinca approved these changes Oct 14, 2016

LGTM

@maasencioh

This comment has been minimized.

Contributor

maasencioh commented Oct 17, 2016

The same question here, I don't think that the freebsd break it's related with the current changes, but how can I be sure?

@lpinca

This comment has been minimized.

Member

lpinca commented Oct 17, 2016

You can check the logs here https://ci.nodejs.org/job/node-test-commit-freebsd/4823/nodes=freebsd11-x64/console to see what failed. In this case:

not ok 1161 parallel/test-tick-processor-unknown
# TIMEOUT

Not something to worry about.

@maasencioh

This comment has been minimized.

Contributor

maasencioh commented Oct 17, 2016

Thanks @lpinca, I read it but see a red flag makes me panic 😛

@rvagg rvagg force-pushed the nodejs:master branch 2 times, most recently to 83c7a88 Oct 18, 2016

@jasnell jasnell self-assigned this Oct 18, 2016

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_client
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_incoming
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_outgoing
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_server
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in http
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 18, 2016

Landed in 23d6e1f...accf410

@jasnell jasnell closed this Oct 18, 2016

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_client
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_incoming
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_outgoing
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in _http_server
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 18, 2016

http: name anonymous functions in http
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@maasencioh maasencioh deleted the maasencioh:name_http_client branch Oct 18, 2016

jasnell added a commit that referenced this pull request Oct 19, 2016

http: name anonymous functions in _http_client
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 19, 2016

http: name anonymous functions in _http_incoming
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 19, 2016

http: name anonymous functions in _http_outgoing
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 19, 2016

http: name anonymous functions in _http_server
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jasnell added a commit that referenced this pull request Oct 19, 2016

http: name anonymous functions in http
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment