New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit Stream api grammar #9100

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@bcmarinacci
Member

bcmarinacci commented Oct 14, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Sections:

  • Introduction
  • Orginization of this Document
  • Object Mode
  • Buffering
  • API for Stream Implementers
doc: edit Stream api grammar
Sections:
  - Introduction
  - Orginization of this Document
  - Object Mode
  - Buffering
  - API for Stream Implementers
@jasnell

LGTM

@addaleax

LGTM

@@ -1061,7 +1061,7 @@ Examples of Transform streams include:
<!--type=misc-->
The `stream` module API has been designed to make it possible to easily
implement streams using JavaScript's prototypical inheritance model.
implement streams using JavaScript's prototypal inheritance model.

This comment has been minimized.

@addaleax

addaleax Oct 14, 2016

Member

http://www.merriam-webster.com/dictionary/prototypal ;)

(not complaining, I just giggled a bit at this. 😄)

jasnell added a commit that referenced this pull request Oct 17, 2016

doc: edit Stream api grammar
Sections:
  - Introduction
  - Orginization of this Document
  - Object Mode
  - Buffering
  - API for Stream Implementers

PR-URL: #9100
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 17, 2016

Landed in 3c4349e. Thank you!

@jasnell jasnell closed this Oct 17, 2016

jasnell added a commit that referenced this pull request Oct 17, 2016

doc: edit Stream api grammar
Sections:
  - Introduction
  - Orginization of this Document
  - Object Mode
  - Buffering
  - API for Stream Implementers

PR-URL: #9100
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Nov 11, 2016

doc: edit Stream api grammar
Sections:
  - Introduction
  - Orginization of this Document
  - Object Mode
  - Buffering
  - API for Stream Implementers

PR-URL: #9100
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v6.9.2 proposal #9735

@bcmarinacci bcmarinacci deleted the bcmarinacci:doc-stream branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment