Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add 2016-10-19 CTC meeting minutes #9193

Closed
wants to merge 1 commit into from

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Oct 19, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

as in title

/cc @nodejs/ctc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 19, 2016
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


@trott: Is this a semver-major change?

@jasnell: No, especially cause this is an experimental feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: No, especially cause -> No because

* Julien Gilli @misterdjules (CTC)
* nothing too significant
* Mikeal Rogers @mikeal (observer/Node.js Foundation)
* Putting together bugeting stuff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

budgeting?

* HTTP/2 implementation
* PRs
* Josh Gavant @joshgav (observer/Microsoft)
* PR’s to improve user experience with new debugger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: PRs

* mostly PR reviews
* Trevor Norris @trevnorris (CTC)
* Worked with Matt Loring, proposed promise hooks api is
sufficient combined with debugger API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence could be improved.

jasnell pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #9193
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 26, 2016

Landed in 0c61b4d

@jasnell jasnell closed this Oct 26, 2016
@joshgav joshgav deleted the ctc-2016-10-19 branch October 27, 2016 20:08
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
PR-URL: #9193
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9193
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9193
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants