New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove arbitrary timer #9197

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Trott
Member

Trott commented Oct 19, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

Description of change

This test was timing out (via the 200ms timeout in the code) on FreeBSD in CI. The 200ms timeout is arbitrary and not necessary. Remove it.

/cc @nodejs/testing

test: remove arbitrary timer
This test was timing out (via the 200ms timeout in the code) on FreeBSD
in CI. The 200ms timeout is arbitrary and not necessary. Remove it.
@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Member

Trott commented Oct 19, 2016

One CI failure is unrelated (and is the other thorny problem on FreeBSD)... Everything else in CI is green.

@lpinca

lpinca approved these changes Oct 20, 2016

Trott added a commit to Trott/io.js that referenced this pull request Oct 21, 2016

test: remove arbitrary timer
`test-dgram-send-callback-buffer-length` was timing out (via the
200ms timeout in the code) on FreeBSD in CI. The 200ms timeout is
arbitrary and not necessary. Remove it.

PR-URL: nodejs#9197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Member

Trott commented Oct 21, 2016

Landed in f99e698

@Trott Trott closed this Oct 21, 2016

jasnell added a commit that referenced this pull request Oct 24, 2016

test: remove arbitrary timer
`test-dgram-send-callback-buffer-length` was timing out (via the
200ms timeout in the code) on FreeBSD in CI. The 200ms timeout is
arbitrary and not necessary. Remove it.

PR-URL: #9197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 15, 2016

test: remove arbitrary timer
`test-dgram-send-callback-buffer-length` was timing out (via the
200ms timeout in the code) on FreeBSD in CI. The 200ms timeout is
arbitrary and not necessary. Remove it.

PR-URL: #9197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v6.9.2 proposal #9735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment