test: use 'strictEqual' instead of 'equal' #9297
Conversation
|
Can the |
mscdex
added
async_wrap
async_hooks
|
Oh, I missed that. I made the change and tested it, and it passed. |
|
I noticed that some of the checks reported on GitHub as "not successful". Does the tests currently have some flaky issues? If so, is there a ticket already reporting more details on this to look into? |
|
There are a lot of test/CI issues right now, unfortunately. Failures are very likely to be unrelated to these changes. |
|
So what is the current process in these cases? I believe having deterministic tests is vital. I'll work on that as I get more familiar with the code base and tests. |
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: nodejs#9297 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 758ca8d |
Collaborators know what known-issues to ignore (hopefully). In the meantime, people are working to fix stuff. If you want to help with that sort of thing specifically, places to look include: |
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: #9297 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: #9297 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: #9297 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesDescription of change
Use 'strictEqual' instead of 'equal' in 'test-async-wrap-check-providers'.