Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-fs-watch-recursive on OS X #9303

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-fs-watch-recursive on OS X #9303

wants to merge 1 commit into from

Commits on Oct 26, 2016

  1. test: fix flaky test-fs-watch-recursive on OS X 

    The test was sometimes timing out due to a race condition. In OS X,
events for `fs.watch()` might only start showing up after a delay. This
is a limitation of the operating system. To work around that, there was
a timer in the test that delayed the writing of the file by 100ms.
However, sometimes that was not enough, and so the event never fired,
and the test timed out.

Change the timer to an interval so that it fires repeatedly until it is
picked up. This change only affects OS X.

Fixes: nodejs#8511
    @Trott
    Trott committed Oct 26, 2016
    Configuration menu
    Copy the full SHA
    f621f81 View commit details
    Browse the repository at this point in the history