Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove timers from streams test #9360

Closed
wants to merge 4 commits into from
Closed

test: remove timers from streams test #9360

wants to merge 4 commits into from

Commits on Oct 29, 2016

  1. test: remove timers from streams test 

    test-stream2-readable-empty-buffer-no-eof fails on resource-constrained
machines due to its use of timers. Removing timers makes it more
reliable and doesn’t affect the validity of the test, as it only uses
relative timing relations.

Failures were noticed on freebsd10-64 in CI. I am able to replicate the
failure with `tools/test.py --repeat=100 -j 100`. When run alone, it
passes reliably.
    @addaleax
    addaleax committed Oct 29, 2016
    Copy the full SHA
    b8ffd20 View commit details
    Browse the repository at this point in the history

  2. address nit

    @addaleax
    addaleax committed Oct 29, 2016
    Copy the full SHA
    c866994 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2016

  1. address nits for readability

    @addaleax
    addaleax committed Oct 30, 2016
    Copy the full SHA
    88c42da View commit details
    Browse the repository at this point in the history

  2. reverse order of tests for clarity

    @addaleax
    addaleax committed Oct 30, 2016
    Copy the full SHA
    e8c82ed View commit details
    Browse the repository at this point in the history