Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: default --icu_case_mapping on as a v8 option #9454

Closed
wants to merge 1 commit into from
Closed

src: default --icu_case_mapping on as a v8 option #9454

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 3, 2016

  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change
  • toLocaleUpperCase() and toLocaleLowerCase() do not function properly
    without this flag.
  • basic test case. The test case would fail if --no_icu_case_mapping
    was set.

Fixes: #9445

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 3, 2016
@srl295 srl295 self-assigned this Nov 3, 2016
@srl295 srl295 added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 3, 2016
@mscdex mscdex added i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency. labels Nov 3, 2016
bnoordhuis
bnoordhuis approved these changes Nov 3, 2016
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a style nit

src/node.cc
@@ -4191,6 +4191,14 @@ void Init(int* argc,
DispatchDebugMessagesAsyncCallback));
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));

#if defined(NODE_HAVE_I18N_SUPPORT)
// set the ICU casing flag early
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you capitalize the comment?

@srl295
Copy link
Member Author

srl295 commented Nov 3, 2016

@evanlucas also said

I wonder if we could just bake that flag in to node.gyp

@srl295
Copy link
Member Author

srl295 commented Nov 4, 2016 •
edited

I don't know why the linter is failing in the automated build. Can't reproduce… any ideas @nodejs/build ?

$ make lint-ci
./node tools/jslint.js  -f tap -o test-eslint.tap \
        benchmark lib test tools
Total errors found: 0

update seems to be working now.

@srl295
src: default --icu_case_mapping on as a v8 option
0d71729 
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly
without this flag.
* basic test case. The test case would fail if `--no_icu_case_mapping`
was set.

Fixes: nodejs#9445
PR-URL: nodejs#9454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

I wonder if we could just bake that flag in to node.gyp

Could for sure, but we don't do that for other flags.

@srl295
Copy link
Member Author

srl295 commented Nov 4, 2016

Landed in 1a55e9a

@srl295 srl295 closed this Nov 4, 2016
@srl295 srl295 deleted the default_icu_case_mapping branch November 4, 2016 16:50
srl295 added a commit that referenced this pull request Nov 4, 2016
@srl295
src: default --icu_case_mapping on as a v8 option
1a55e9a 
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly
without this flag.
* basic test case. The test case would fail if `--no_icu_case_mapping`
was set.

Fixes: #9445
PR-URL: #9454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
@srl295 @evanlucas
src: default --icu_case_mapping on as a v8 option
b1ef638 
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly
without this flag.
* basic test case. The test case would fail if `--no_icu_case_mapping`
was set.

Fixes: #9445
PR-URL: #9454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@evanlucas evanlucas mentioned this pull request Nov 7, 2016
Merged
@gibfahn gibfahn mentioned this pull request Apr 24, 2017
Closed
31 tasks
@MylesBorins
Copy link
Member

MylesBorins commented May 15, 2017 •
edited

landed this on v6.x and got the error "Error: unrecognized flag --icu_case_mapping"

not landing for now. LMK if we should consider it

@srl295
Copy link
Member Author

srl295 commented Aug 31, 2017

@MylesBorins no, incompatible with older v8. And new v8 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@srl295 srl295

Labels
c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@srl295 @bnoordhuis @MylesBorins @jasnell @mscdex @gibfahn @nodejs-github-bot