Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: don't call into VM from AsyncWrap destructor #9467

Closed
wants to merge 2 commits into from
Closed

src: don't call into VM from AsyncWrap destructor #9467

wants to merge 2 commits into from

Commits on Nov 4, 2016

  1. src: don't call into VM from AsyncWrap destructor 

    It is not allowed anymore to call JS code when collecting weakly
persistent handles, it hits the assertion below:

    # Fatal error in ../deps/v8/src/execution.cc, line 103
    # Check failed: AllowJavascriptExecution::IsAllowed(isolate).

Remove the call into the VM from the AsyncWrap destructor.  This commit
breaks the destroy hook but that cannot be helped.

Fixes: nodejs#8216
    @bnoordhuis
    bnoordhuis committed Nov 4, 2016
    Configuration menu
    Copy the full SHA
    7206606 View commit details
    Browse the repository at this point in the history

  2. squash! remove async_hooks_destroy_function

    @bnoordhuis
    bnoordhuis committed Nov 4, 2016
    Configuration menu
    Copy the full SHA
    1ffda6b View commit details
    Browse the repository at this point in the history