Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix helper-debugger-repl.js #9486

Closed
wants to merge 1 commit into from
Closed

Commits on Nov 6, 2016

  1. test: fix helper-debugger-repl.js

    The test `debugger/test-debugger-repl-break-in-module` (and probably
    others) was failing because the handshake message for debugging is no
    longer `listening on port <port>` but is instead `listening on
    <address>:<port>`.
    
    This change makes the check less strict so as to hopefully future-proof
    it at least a little bit against subsequent changes.
    
    This test failure is not caught in CI because currently debugger tests
    are not run in CI.
    Trott committed Nov 6, 2016
    Configuration menu
    Copy the full SHA
    72640f5 View commit details
    Browse the repository at this point in the history