doc: fix type of http.request's agent option
#9584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Nov 13, 2016
lpinca
reviewed
Nov 13, 2016
| @@ -1518,7 +1518,7 @@ added: v0.3.6 | |||
| * `headers` {Object} An object containing request headers. | |||
| * `auth` {String} Basic authentication i.e. `'user:password'` to compute an | |||
| Authorization header. | |||
| * `agent` {String} Controls [`Agent`][] behavior. When an Agent is used request will | |||
| * `agent` {http.Agent|Boolean} Controls [`Agent`][] behavior. When an Agent is used request will | |||
There was a problem hiding this comment.
Nit: long line. Please wrap it at 80 chars if you can.
silverwind
approved these changes
Nov 15, 2016
silverwind
pushed a commit
that referenced
this pull request
Nov 15, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind
pushed a commit
that referenced
this pull request
Nov 15, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Fix a typo added by myself in #8486.