New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: fix building v8 on libc++ 3.8.0 #9763

Closed
wants to merge 1 commit into
base: v4.x-staging
from

Conversation

Projects
None yet
6 participants
@jbergstroem
Member

jbergstroem commented Nov 23, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps/v8

Description of change

Make sure the map allocators are of the same type. This fixes building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467

/cc @thealphanerd

@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

jbergstroem Nov 23, 2016

Member

CI: https://ci.nodejs.org/job/node-test-commit/6154/

(I've disabled the nodejs 4.x/freebsd 11 skip)

Member

jbergstroem commented Nov 23, 2016

CI: https://ci.nodejs.org/job/node-test-commit/6154/

(I've disabled the nodejs 4.x/freebsd 11 skip)

@bnoordhuis

LGTM but you should bump the patch level in v8-version.h.

@MylesBorins MylesBorins changed the base branch from v4.x to v4.x-staging Nov 23, 2016

@MylesBorins

LGTM

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 28, 2016

Member

V8: CI

will land if green

/cc @nodejs/v8 to ensure this is ok to float... as the version of V8 on v4.x is unmaintained I can't think of a better way to do this

Member

MylesBorins commented Nov 28, 2016

V8: CI

will land if green

/cc @nodejs/v8 to ensure this is ok to float... as the version of V8 on v4.x is unmaintained I can't think of a better way to do this

@jbajwa

This comment has been minimized.

Show comment
Hide comment
@jbajwa

jbajwa Nov 28, 2016

Member

I think rebase is required as the base branch is switched to nodejs:v4.x-staging from nodejs:v4.x. nodejs:v4.x doesn't have the updated make-v8.sh hence we are seeing the CI failures

Member

jbajwa commented Nov 28, 2016

I think rebase is required as the base branch is switched to nodejs:v4.x-staging from nodejs:v4.x. nodejs:v4.x doesn't have the updated make-v8.sh hence we are seeing the CI failures

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Nov 29, 2016

Contributor

For posterity, upstream has this fix in v8/v8@96cb909 (partially). js-type-feedback.h no longer exists upstream, so I don't see a corresponding upstream commit for that.

Contributor

ofrobots commented Nov 29, 2016

For posterity, upstream has this fix in v8/v8@96cb909 (partially). js-type-feedback.h no longer exists upstream, so I don't see a corresponding upstream commit for that.

@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

jbergstroem Nov 29, 2016

Member

@ofrobots: cool, thanks for bringing it upstream!

Member

jbergstroem commented Nov 29, 2016

@ofrobots: cool, thanks for bringing it upstream!

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Nov 30, 2016

Contributor

@jbergstroem to be clear, I didn't bring it upstream. Relevant upstream branches (other than the one corresponding to v4.x) already had the fix.

Contributor

ofrobots commented Nov 30, 2016

@jbergstroem to be clear, I didn't bring it upstream. Relevant upstream branches (other than the one corresponding to v4.x) already had the fix.

deps: fix build with libc++ 3.8.0
Make sure the map allocators are of the same type. This fixes
building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 30, 2016

Member

I've gone ahead and rebased... one more go at CI

https://ci.nodejs.org/job/node-test-commit-v8-linux/444/

Member

MylesBorins commented Nov 30, 2016

I've gone ahead and rebased... one more go at CI

https://ci.nodejs.org/job/node-test-commit-v8-linux/444/

MylesBorins added a commit that referenced this pull request Dec 1, 2016

deps: fix build with libc++ 3.8.0
Make sure the map allocators are of the same type. This fixes
building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467

PR-URL: #9763
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Dec 1, 2016

Member

the failures on the v8 CI are appearing on v4.6.2, unrelated to this change.

Landed in c1effb1

Member

MylesBorins commented Dec 1, 2016

the failures on the v8 CI are appearing on v4.6.2, unrelated to this change.

Landed in c1effb1

@MylesBorins MylesBorins closed this Dec 1, 2016

@MylesBorins MylesBorins referenced this pull request Dec 6, 2016

Merged

v4.7.0 proposal #9736

BethGriggs added a commit to ibmruntimes/node that referenced this pull request Dec 7, 2016

deps: fix build with libc++ 3.8.0
Make sure the map allocators are of the same type. This fixes
building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).

Upstream bug/patch: https://bugs.freebsd.org/208467

PR-URL: nodejs/node#9763
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment