clear out const/let #9878
Closed
clear out const/let #9878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Dec 1, 2016
|
@stpCollabr8nLstn May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
stpCollabr8nLstn
force-pushed
the
notMaster
branch
from
31f9f33
to
897b073
Compare
|
@imyller fixed |
imyller
added
the
code-and-learn
|
@stpCollabr8nLstn Thank you. Looks good 👍 |
lpinca
reviewed
Dec 2, 2016
| var common = require('../common'); | ||
| var assert = require('assert'); | ||
| const common = require('../common'); | ||
| const assert = require('assert'); |
There was a problem hiding this comment.
Nit: I think it's ok to move the assert require after the common.hasCrypto check.
I'm pointing this out because other tests do this and it would be nice for consistency.
Thanks.
lpinca
approved these changes
Dec 2, 2016
|
@stpCollabr8nLstn The commit author details have your name as |
|
@gibfahn is there a way to retroactively change that? |
git commit --no-edit --amend --author="Jane Q. Public <email@example.com>"
git push --force-with-lease origin notMasterTo change it globally so it will be the default for future commits: git config --global user.name "Jane Q. Public" |
stpCollabr8nLstn
force-pushed
the
notMaster
branch
from
b85439e
to
c6423ce
Compare
|
thanks @Trott done |
clear out const/let change assert.notEqual to assert move assert after common.hasCrypto check
|
Even though the code shouldn't have changed, it's probably a good practice to always re-run CI after a force push, so.... |
gibfahn
approved these changes
Dec 3, 2016
targos
approved these changes
Dec 3, 2016
|
Landed in efa8456. |
jasnell
reviewed
Dec 3, 2016
targos
pushed a commit
that referenced
this pull request
Dec 3, 2016
clear out const/let change assert.notEqual to assert move assert after common.hasCrypto check PR-URL: #9878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
clear out const/let change assert.notEqual to assert move assert after common.hasCrypto check PR-URL: #9878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
clear out const/let change assert.notEqual to assert move assert after common.hasCrypto check PR-URL: nodejs#9878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
clear out const/let change assert.notEqual to assert move assert after common.hasCrypto check PR-URL: nodejs#9878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
clear out const/let change assert.notEqual to assert move assert after common.hasCrypto check PR-URL: #9878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
change let to const/let
change assert.notEqual to assert