Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use assert.strictEqual in test-cli-eval #9919

Closed
wants to merge 1 commit into from
Closed

test: use assert.strictEqual in test-cli-eval #9919

wants to merge 1 commit into from

Conversation

NigelKibodeaux
Copy link
Contributor

@NigelKibodeaux NigelKibodeaux commented Dec 1, 2016 •
edited

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Being more strict about comparisons here, especially since many comparisons are against an empty string which would equal, but not strictly equal, false.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
not-an-aardvark
not-an-aardvark approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cjihrig
cjihrig approved these changes Dec 4, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, but it would be very useful to add common.mustCall() around all of the exec() callback functions while you're in here.

jasnell
jasnell approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without the additional mustCall updates.

@Trott
Copy link
Member

Trott commented Dec 6, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5238/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2016
@NigelKibodeaux @Trott
test: use assert.strictEqual in test-cli-eval
95ac3bd 
PR-URL: nodejs#9919
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 6, 2016
@Trott
Copy link
Member

Trott commented Dec 6, 2016

Landed in 95ac3bd.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@NigelKibodeaux @Fishrock123
test: use assert.strictEqual in test-cli-eval
d697ac4 
PR-URL: #9919
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@NigelKibodeaux @addaleax
test: use assert.strictEqual in test-cli-eval
050bae6 
PR-URL: nodejs#9919
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@NigelKibodeaux
test: use assert.strictEqual in test-cli-eval
262344e 
PR-URL: nodejs#9919
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@NigelKibodeaux @MylesBorins
test: use assert.strictEqual in test-cli-eval
ad27555 
PR-URL: #9919
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@NigelKibodeaux @MylesBorins
test: use assert.strictEqual in test-cli-eval
3b3b349 
PR-URL: #9919
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@NigelKibodeaux @MylesBorins
test: use assert.strictEqual in test-cli-eval
f9c5054 
PR-URL: #9919
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet