Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: convert assert.equal to assert.strictEqual #9925

Closed
wants to merge 1 commit into from
Closed

test: convert assert.equal to assert.strictEqual #9925

wants to merge 1 commit into from

Conversation

jmdarling
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

converts an instance of assert.equal in a file already mostly updated to
use assert.strictEqual

test: convert assert.equal to assert.strictEqual
3e6ecd7 
converts an instance of assert.equal in a file already mostly updated to
use assert.strictEqual
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. and removed test Issues and PRs related to the tests. labels Dec 1, 2016
@imyller imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed test Issues and PRs related to the tests. labels Dec 1, 2016
@mscdex mscdex added the test Issues and PRs related to the tests. label Dec 1, 2016
@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5203/

jasnell pushed a commit that referenced this pull request Dec 6, 2016
@jasnell
test: convert assert.equal to assert.strictEqual
6ed0e8b 
converts an instance of assert.equal in a file already mostly
updated to use assert.strictEqual

PR-URL: #9925
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 6, 2016

Landed in 6ed0e8b. Thank you for the PR and for participating in the code-and-learn!

@jasnell jasnell closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@Fishrock123
test: convert assert.equal to assert.strictEqual
8e27254 
converts an instance of assert.equal in a file already mostly
updated to use assert.strictEqual

PR-URL: #9925
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test: convert assert.equal to assert.strictEqual
0010398 
converts an instance of assert.equal in a file already mostly
updated to use assert.strictEqual

PR-URL: nodejs#9925
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
test: convert assert.equal to assert.strictEqual
1436fd7 
converts an instance of assert.equal in a file already mostly
updated to use assert.strictEqual

PR-URL: #9925
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
test: convert assert.equal to assert.strictEqual
6dbff7a 
converts an instance of assert.equal in a file already mostly
updated to use assert.strictEqual

PR-URL: #9925
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: convert assert.equal to assert.strictEqual
b997a7e 
converts an instance of assert.equal in a file already mostly
updated to use assert.strictEqual

PR-URL: #9925
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: convert assert.equal to assert.strictEqual
e2791de 
converts an instance of assert.equal in a file already mostly
updated to use assert.strictEqual

PR-URL: #9925
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jmdarling @jasnell @addaleax @cjihrig @mscdex @MylesBorins @imyller @nodejs-github-bot