Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change assert.equal to assert.strictEqual #9956

Closed
wants to merge 1 commit into from
Closed

test: change assert.equal to assert.strictEqual #9956

wants to merge 1 commit into from

Conversation

crokita
Copy link
Contributor

@crokita crokita commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX)
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Use assert.strictEqual() instead of assert.equal() for lines 11, 12, 13, 14, 21, 22, 23, 24, 28

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

First line of commit message is too long, see the commit message guidelines here.

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@crokita crokita changed the title test: change assert.equal to assert.strictEqual in file test: change assert.equal to assert.strictEqual Dec 1, 2016
jasnell
jasnell approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commits will need to be squashed and a new-line needs to be added at the end of the file to pass linting.

@Trott
Copy link
Member

Trott commented Dec 8, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5327/

@Trott
Copy link
Member

Trott commented Dec 22, 2016

ping @crokita: Can you add a newline to the end of the file? Even better if you can squash the commits into a single commit, but that can also be done by whoever lands the change.

@crokita
Copy link
Contributor Author

crokita commented Dec 22, 2016

Yep! Updated the branch. Does this look okay @Trott ?

Trott
Trott approved these changes Dec 22, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is ✅

@Trott
Copy link
Member

Trott commented Dec 22, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5538/

@italoacasas
Copy link
Contributor

Landed 70d752e

italoacasas pushed a commit that referenced this pull request Dec 23, 2016
@crokita @italoacasas
test: refactoring test-cluster-worker-constructor
70d752e 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@Trott
Copy link
Member

Trott commented Dec 23, 2016

Thanks for the contribution @crokita! 🎉

targos pushed a commit that referenced this pull request Dec 26, 2016
@crokita @targos
test: refactoring test-cluster-worker-constructor
77334a2 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@MylesBorins MylesBorins mentioned this pull request Dec 27, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@crokita @targos
test: refactoring test-cluster-worker-constructor
c63009d 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@crokita @evanlucas
test: refactoring test-cluster-worker-constructor
2a4c5ff 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@crokita @evanlucas
test: refactoring test-cluster-worker-constructor
14826d0 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@crokita @MylesBorins
test: refactoring test-cluster-worker-constructor
a123e8c 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@crokita @MylesBorins
test: refactoring test-cluster-worker-constructor
6bdd59a 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@crokita @MylesBorins
test: refactoring test-cluster-worker-constructor
d5e911c 
- Using assert.strictEqual instead assert.equal

PR-URL: #9956
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@italoacasas italoacasas italoacasas approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@crokita @mscdex @Trott @italoacasas @jasnell @imyller @targos @nodejs-github-bot