test: updated to const and strictEqual #9974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
the
code-and-learn
|
|
Upadted all var to const/let and updated assert.equal to assert.strictEqual
ghvaldez
force-pushed
the
greg-valdez-update-test
branch
from
8d3c3ed
to
f3e3d79
Compare
|
@mscdex updated commit message |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
Updated all remaining var to const PR-URL: nodejs#9974 Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 7837866. Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Updated all remaining var to const PR-URL: #9974 Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Updated all remaining var to const PR-URL: nodejs#9974 Reviewed-By: Rich Trott <rtrott@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Updated all remaining var to const PR-URL: nodejs#9974 Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Updated all remaining var to const PR-URL: #9974 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Tests
Description of change
Upadted all var to const/let and updated assert.equal to
assert.strictEqual