Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use assert.strictEqual #9975

Closed
wants to merge 1 commit into from
Closed

test: use assert.strictEqual #9975

wants to merge 1 commit into from

Conversation

anoff
Copy link
Contributor

@anoff anoff commented Dec 1, 2016

this is a code-and-learn issue

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • use assert.strictEqual

@anoff
test: use assert.strictEqual
e34d6cc 
* use `assert.strictEqual`
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added the debugger label Dec 1, 2016
princejwesley
princejwesley approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@princejwesley princejwesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line in commit message can be test: refactor test-debug-port-from-cmdline

@anoff
Copy link
Contributor Author

anoff commented Dec 2, 2016

@princejwesley can or should?

cjihrig
cjihrig approved these changes Dec 3, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM. The commit message should be more descriptive.

@addaleax
Copy link
Member

addaleax commented Dec 8, 2016

Landed in deb9cc0, thanks for the contribution!

@addaleax addaleax closed this Dec 8, 2016
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@anoff @addaleax
test: use assert.strictEqual
deb9cc0 
* use `assert.strictEqual`

PR-URL: #9975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@anoff @addaleax
test: use assert.strictEqual
b67cad1 
* use `assert.strictEqual`

PR-URL: #9975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@anoff @addaleax
test: use assert.strictEqual
1288d07 
* use `assert.strictEqual`

PR-URL: nodejs#9975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@anoff @MylesBorins
test: use assert.strictEqual
9b974b4 
* use `assert.strictEqual`

PR-URL: #9975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@anoff @MylesBorins
test: use assert.strictEqual
2edfeb9 
* use `assert.strictEqual`

PR-URL: #9975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@anoff @MylesBorins
test: use assert.strictEqual
9309160 
* use `assert.strictEqual`

PR-URL: #9975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@princejwesley princejwesley princejwesley approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@anoff @addaleax @jasnell @princejwesley @cjihrig @mscdex @MylesBorins @imyller @nodejs-github-bot