test: change indexOf to includes in ecdh-disable #9989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates test/parallel/test-tls-ecdh-disable.js on line 34 so that assert.notEqual is changed to just assert. Then in place of indexOf, includes() is used. The callback on line 31 has been wrapped in common.mustCall() in order to ensure that this callback is only made one time.
imyller
added
the
code-and-learn
ancapaaron
force-pushed
the
node_interactive_test
branch
from
4c0e950
to
4b083b7
Compare
|
nit: there's a typo in the commit message |
ancapaaron
changed the title
|
@mscdex Thanks! I force pushed and updated. |
cjihrig
requested changes
Dec 3, 2016
| @@ -28,10 +28,10 @@ server.listen(0, '127.0.0.1', function() { | |||
| if (common.isWindows) | |||
| cmd += ' -no_rand_screen'; | |||
|
|
|||
| exec(cmd, function(err, stdout, stderr) { | |||
| exec(cmd, common.mustCall(function(err, stdout, stderr) { | |||
There was a problem hiding this comment.
This also needs a common.mustCall() on the server.listen() callback.
There was a problem hiding this comment.
@cjihrig Went ahead and updated this. Thank you for the feedback.
Wraps the callback on the server.listen function in common.mustCall.
cjihrig
approved these changes
Dec 5, 2016
jasnell
approved these changes
Dec 5, 2016
lpinca
approved these changes
Dec 9, 2016
|
Unrelated failure on SmartOS |
|
Landed in 885c80f. Thanks! |
lpinca
pushed a commit
that referenced
this pull request
Dec 16, 2016
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Dec 17, 2016
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
* use common.mustCall() * use String.prototype.includes() instead of String.prototype.indexOf() PR-URL: #9989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Updates test/parallel/test-tls-ecdh-disable.js on line 34 so that
assert.notEqual is changed to just assert. Then in place of indexOf,
includes() is used. The callback on line 31 has been wrapped in
common.mustCall() in order to ensure that this callback is only
made one time.