Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Test: Add more tests for SideNavBar component #2845

Merged
merged 2 commits into from Oct 2, 2022

Conversation

forgeRW
Copy link
Contributor

@forgeRW forgeRW commented Oct 1, 2022

Description

I added more unit tests for SideNavBar component.

  • Add tests for rest of the items
  • Add tests for rendering https link and closing a link after clicking it

Related Issues

Related to #2744

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

* Add tests for rest of the items
* Add tests for rendering https link and closing a link after clicking it
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Base: 66.02% // Head: 63.51% // Decreases project coverage by -2.51% ⚠️

Coverage data is based on head (729bcd7) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2845      +/-   ##
==========================================
- Coverage   66.02%   63.51%   -2.52%     
==========================================
  Files         118      123       +5     
  Lines        1351     1458     +107     
  Branches      342      364      +22     
==========================================
+ Hits          892      926      +34     
- Misses        422      492      +70     
- Partials       37       40       +3     
Impacted Files Coverage Δ
src/__fixtures__/page.tsx 94.11% <ø> (-5.89%) ⬇️
...components/ApiComponents/Components/ApiHeading.tsx 0.00% <ø> (ø)
...rc/components/ApiComponents/Components/ApiLink.tsx 0.00% <ø> (ø)
...ents/ApiComponents/Components/SourceLink/index.tsx 0.00% <ø> (ø)
...ApiComponents/Components/VersionSelector/index.tsx 0.00% <ø> (ø)
src/components/ApiComponents/index.tsx 0.00% <ø> (ø)
src/components/Article/index.tsx 100.00% <ø> (ø)
src/components/Banner/index.tsx 100.00% <ø> (ø)
src/components/Codebox/index.tsx 100.00% <ø> (ø)
src/components/EditLink/index.tsx 100.00% <ø> (ø)
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for your first contribution!

@ovflowd ovflowd added the hacktoberfest-accepted Used to label PR's label Oct 2, 2022
@ovflowd ovflowd merged commit a449b82 into nodejs:main Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Used to label PR's
Projects
None yet
4 participants